Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NXP][Zephyr] Add experimental Ethernet support to NXP zephyr platforms #35643

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[NXP][Zephyr] Add experimental Ethernet support to NXP zephyr platforms #35643

merged 3 commits into from
Sep 18, 2024

Conversation

axelnxp
Copy link
Contributor

@axelnxp axelnxp commented Sep 18, 2024

  • Enable Ethernet for RW61x platform
  • Add ethernet support in following examples:
    • All-clusters-app
    • Laudry washer
    • Thermostat
  • Support ethernet build with build_examples.py and add it to workflows

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 18, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 2 of 33 files.

Overall, the semantic diff is 15% smaller than the GitHub diff.

File Information
Filename Status
❔ src/platform/telink/CHIPDevicePlatformConfig.h Unsupported file format
❔ src/platform/nxp/zephyr/BUILD.gn Unsupported file format
❔ src/platform/nxp/zephyr/ConnectivityManagerImpl.cpp Unsupported file format
❔ src/platform/nxp/zephyr/ConnectivityManagerImpl.h Unsupported file format
❔ src/platform/nxp/zephyr/args.gni Unsupported file format
❔ src/platform/nxp/zephyr/Ethernet/ConnectivityManagerImplEth.cpp Unsupported file format
❔ src/platform/nxp/zephyr/Ethernet/ConnectivityManagerImplEth.h Unsupported file format
❔ src/platform/nxp/zephyr/Ethernet/EthManager.cpp Unsupported file format
❔ src/platform/nxp/zephyr/Ethernet/EthManager.h Unsupported file format
❔ src/platform/nxp/zephyr/Ethernet/NxpEthDriver.cpp Unsupported file format
❔ src/platform/nxp/zephyr/Ethernet/NxpEthDriver.h Unsupported file format
❔ src/platform/Zephyr/ConfigurationManagerImpl.cpp Unsupported file format
❔ scripts/build/testdata/all_targets_linux_x64.txt Unsupported file format
✔️ scripts/build/builders/nxp.py 17.34% smaller
✔️ scripts/build/build/targets.py Analyzed
❔ examples/thermostat/nxp/zephyr/prj_ethernet.conf Unsupported file format
❔ examples/thermostat/nxp/zephyr/boards/rd_rw612_bga_ethernet.overlay Unsupported file format
❔ examples/thermostat/nxp/zephyr/boards/rd_rw612_bga_ethernet_fdata.conf Unsupported file format
❔ examples/platform/nxp/common/app_task/source/AppTaskBase.cpp Unsupported file format
❔ examples/platform/nxp/common/app_task/source/AppTaskZephyr.cpp Unsupported file format
❔ examples/platform/nxp/common/app_task/include/AppTaskBase.h Unsupported file format
❔ examples/platform/nxp/common/app_task/include/AppTaskZephyr.h Unsupported file format
❔ examples/laundry-washer-app/nxp/zephyr/prj_ethernet.conf Unsupported file format
❔ examples/laundry-washer-app/nxp/zephyr/boards/rd_rw612_bga_ethernet.overlay Unsupported file format
❔ examples/laundry-washer-app/nxp/zephyr/boards/rd_rw612_bga_ethernet_fdata.conf Unsupported file format
❔ examples/all-clusters-app/nxp/zephyr/prj_ethernet.conf Unsupported file format
❔ examples/all-clusters-app/nxp/zephyr/boards/rd_rw612_bga_ethernet.overlay Unsupported file format
❔ examples/all-clusters-app/nxp/zephyr/boards/rd_rw612_bga_ethernet_fdata.conf Unsupported file format
❔ config/nxp/cmake/common.cmake Unsupported file format
❔ config/nxp/chip-module/CMakeLists.txt Unsupported file format
❔ config/nxp/chip-module/Kconfig.defaults Unsupported file format
❔ config/nxp/chip-module/Kconfig.features Unsupported file format
❔ .github/workflows/examples-nxp.yaml Unsupported file format

@axelnxp
[NXP][Zephyr] Add experimental Ethernet support to nxp zephyr platforms
a1c44c1 
* Enable Ethernet for RW61x platform
* Add ethernet support in following examples:
  * All-clusters-app
  * Laudry washer
  * Thermostat
* Support ethernet build with build_examples.py and add it to workflows

Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
@github-actions GitHub Actions
Copy link

PR #35643: Size comparison from e6a6425 to c5b8720

Full report (1 build for stm32)
platform target config section e6a6425 c5b8720 change % change
stm32 light STM32WB5MM-DK FLASH 480576 480576 0 0.0
RAM 144668 144668 0 0.0

@axelnxp
[Telink] Define CHIP_DEVICE_CONFIG_ENABLE_ETHERNET as required by sha…
f36d6b0 
…red Zephyr platform

Like nrfconnect platform, define CHIP_DEVICE_CONFIG_ENABLE_ETHERNET to 0
as required by share Zephyr platform files.

Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

PR #35643: Size comparison from e6a6425 to f36d6b0

Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e6a6425 f36d6b0 change % change
bl602 lighting-app bl602 FLASH 1277856 1277856 0 0.0
RAM 95824 95824 0 0.0
bl602+mfd FLASH 1291966 1291966 0 0.0
RAM 95968 95968 0 0.0
bl602+rpc FLASH 1317068 1317068 0 0.0
RAM 104248 104248 0 0.0
bl702 lighting-app bl702 FLASH 943784 943784 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946184 946184 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039104 1039104 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 645980 645980 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 893736 893736 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960444 960444 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963066 963066 0 0.0
RAM 16964 16964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677269 677269 0 0.0
RAM 78492 78492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697121 697121 0 0.0
RAM 81124 81124 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697121 697121 0 0.0
RAM 81124 81124 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654049 654049 0 0.0
RAM 73560 73560 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613341 613341 0 0.0
RAM 71452 71452 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632977 632977 0 0.0
RAM 74004 74004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632977 632977 0 0.0
RAM 74004 74004 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632589 632589 0 0.0
RAM 74500 74500 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652297 652297 0 0.0
RAM 77052 77052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652297 652297 0 0.0
RAM 77052 77052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608005 608005 0 0.0
RAM 68588 68588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627857 627857 0 0.0
RAM 71220 71220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627857 627857 0 0.0
RAM 71220 71220 0 0.0
efr32 lighting-app BRD4187C FLASH 932380 932380 0 0.0
RAM 135056 135056 0 0.0
lock-app BRD2605a FLASH 739960 739952 -8 -0.0
RAM 231212 231212 0 0.0
BRD4338a FLASH 740608 740600 -8 -0.0
RAM 231244 231244 0 0.0
window-app BRD4187C FLASH 1015544 1015536 -8 -0.0
RAM 126996 126996 0 0.0
esp32 all-clusters-app c3devkit DRAM 94064 94064 0 0.0
FLASH 1537046 1537046 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115008 115008 0 0.0
FLASH 1547502 1547502 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2772147 2772147 0 0.0
RAM 128944 128944 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6074318 6074318 0 0.0
RAM 506928 506928 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5407696 5407696 0 0.0
RAM 240640 240640 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4741208 4741208 0 0.0
RAM 217840 217840 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12540702 12540702 0 0.0
RAM 554506 554506 0 0.0
chip-tool-ipv6only arm64 unknown 20320 20320 0 0.0
FLASH 11240596 11240596 0 0.0
RAM 604560 604560 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10893789 10893789 0 0.0
RAM 553546 553546 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4563946 4563946 0 0.0
RAM 204456 204456 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5677521 5677521 0 0.0
RAM 228128 228128 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4790488 4790488 0 0.0
RAM 203928 203928 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4423674 4423674 0 0.0
RAM 197632 197632 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4562420 4562420 0 0.0
RAM 202200 202200 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3102941 3102941 0 0.0
RAM 158712 158712 0 0.0
thermostat-no-ble arm64 unknown 9336 9336 0 0.0
FLASH 4334076 4334076 0 0.0
RAM 242256 242256 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6019749 6019749 0 0.0
RAM 580464 580464 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10747277 10747277 0 0.0
RAM 642384 642384 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 912968 912968 0 0.0
RAM 142175 142175 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884748 884748 0 0.0
RAM 140314 140314 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846476 846476 0 0.0
RAM 141077 141077 0 0.0
light-switch-app nrf52840dk_nrf52840 FLASH 790528 790528 0 0.0
RAM 132155 132155 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934876 934876 0 0.0
RAM 130720 130720 0 0.0
lighting-app nrf52840dk_nrf52840+rpc FLASH 882076 882076 0 0.0
RAM 146574 146574 0 0.0
nrf52840dongle_nrf52840 FLASH 823168 823168 0 0.0
RAM 154436 154436 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 779432 779432 0 0.0
RAM 145584 145584 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 934876 934876 0 0.0
RAM 130720 130720 0 0.0
lock-app nrf52840dk_nrf52840 FLASH 805608 805608 0 0.0
RAM 132710 132710 0 0.0
nrf5340dk_nrf5340_cpuapp FLASH 731156 731156 0 0.0
RAM 132840 132840 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 950884 950884 0 0.0
RAM 131275 131275 0 0.0
pump-app nrf52840dk_nrf52840 FLASH 758432 758432 0 0.0
RAM 131493 131493 0 0.0
pump-controller-app nrf52840dk_nrf52840 FLASH 743624 743624 0 0.0
RAM 131252 131252 0 0.0
nxp contact k32w0+release FLASH 580520 580520 0 0.0
RAM 70720 70720 0 0.0
k32w1+release FLASH 593352 593352 0 0.0
RAM 62896 62896 0 0.0
mcxw71+release FLASH 593104 593104 0 0.0
RAM 62896 62896 0 0.0
light k32w0+release FLASH 616316 616316 0 0.0
RAM 70184 70184 0 0.0
k32w1+release FLASH 679488 679488 0 0.0
RAM 48512 48512 0 0.0
mcxw71+release FLASH 679504 679504 0 0.0
RAM 48512 48512 0 0.0
lock k32w1+release FLASH 701904 701904 0 0.0
RAM 67036 67036 0 0.0
mcxw71+release FLASH 701928 701928 0 0.0
RAM 67036 67036 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1644548 1644548 0 0.0
RAM 210864 210864 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550556 1550556 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1466372 1466372 0 0.0
RAM 200672 200672 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462988 1462988 0 0.0
RAM 225024 225024 0 0.0
qpg lighting-app qpg6105+debug FLASH 659104 659104 0 0.0
RAM 105212 105212 0 0.0
lock-app qpg6105+debug FLASH 616996 616996 0 0.0
RAM 99688 99688 0 0.0
stm32 light STM32WB5MM-DK FLASH 480576 480576 0 0.0
RAM 144668 144668 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621702 621702 0 0.0
RAM 50964 50964 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686942 686942 0 0.0
RAM 148304 148304 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779886 779886 0 0.0
RAM 110756 110756 0 0.0
bridge-app tlsr9258a FLASH 680722 680722 0 0.0
RAM 91620 91620 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621466 621466 0 0.0
RAM 50916 50916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707372 707372 0 0.0
RAM 74256 74256 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624620 624620 0 0.0
RAM 144292 144292 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810028 810028 0 0.0
RAM 99424 99424 0 0.0
lock-app-dfu tlsr9528a FLASH 655218 655218 0 0.0
RAM 66976 66976 0 0.0
ota-requestor-app tlsr9258a FLASH 696698 696698 0 0.0
RAM 91212 91212 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633054 633054 0 0.0
RAM 55792 55792 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610244 610244 0 0.0
RAM 53036 53036 0 0.0
shell tlsr9518adk80d FLASH 467170 467170 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628430 628430 0 0.0
RAM 52636 52636 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652380 652380 0 0.0
RAM 56584 56584 0 0.0
thermostat tlsr9518adk80d FLASH 636974 636974 0 0.0
RAM 53428 53428 0 0.0
window-covering tlsr9118bdk40d FLASH 523150 523150 0 0.0
RAM 97268 97268 0 0.0
tizen all-clusters-app arm unknown 4852 4852 0 0.0
FLASH 1720668 1720668 0 0.0
RAM 88952 88952 0 0.0
chip-tool-ubsan arm unknown 10252 10252 0 0.0
FLASH 17317338 17317338 0 0.0
RAM 7543536 7543536 0 0.0

@mergify mergify bot merged commit 640f21a into project-chip:master Sep 18, 2024
68 checks passed
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@axelnxp @restyled-commits @yyzhong-g
[NXP][Zephyr] Add experimental Ethernet support to NXP zephyr platfor…
b1e89ba 
…ms (project-chip#35643)

* [NXP][Zephyr] Add experimental Ethernet support to nxp zephyr platforms

* Enable Ethernet for RW61x platform
* Add ethernet support in following examples:
  * All-clusters-app
  * Laudry washer
  * Thermostat
* Support ethernet build with build_examples.py and add it to workflows

Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>

* Restyled by gn

* [Telink] Define CHIP_DEVICE_CONFIG_ENABLE_ETHERNET as required by shared Zephyr platform

Like nrfconnect platform, define CHIP_DEVICE_CONFIG_ENABLE_ETHERNET to 0
as required by share Zephyr platform files.

Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>

---------

Signed-off-by: Axel Le Bourhis <axel.lebourhis@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-alex-tache marius-alex-tache marius-alex-tache left review comments

@andy31415 andy31415 andy31415 approved these changes

@chapongatien chapongatien chapongatien approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
config examples github platform review - approved scripts telink workflows zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axelnxp @andy31415 @chapongatien @marius-alex-tache @restyled-commits